0006-S2S-TLS-OpenSSL-Set-the-verification-flags-only-once.patch 1.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445
  1. From 9fa5c1908e866d9480bfaf0516111c4741adbd59 Mon Sep 17 00:00:00 2001
  2. From: Alexander Barton <alex@barton.de>
  3. Date: Tue, 2 Jan 2024 20:55:15 +0100
  4. Subject: [PATCH 06/20] S2S-TLS/OpenSSL: Set the verification flags only once
  5. Set the verification flags in the ConnSSL_SetVerifyProperties_openssl
  6. function only, don't override them in ConnSSL_InitLibrary() afterwards.
  7. No functional changes, now ConnSSL_SetVerifyProperties_openssl() sets
  8. exactly the parameters which ConnSSL_InitLibrary() always overwrote ...
  9. (cherry picked from commit 08647ab1e7cf0d034f2d8987a3cac3201af84e02)
  10. ---
  11. src/ngircd/conn-ssl.c | 6 ++----
  12. 1 file changed, 2 insertions(+), 4 deletions(-)
  13. --- a/src/ngircd/conn-ssl.c
  14. +++ b/src/ngircd/conn-ssl.c
  15. @@ -401,8 +401,6 @@
  16. SSL_OP_NO_SSLv3 | SSL_OP_NO_TLSv1 | SSL_OP_NO_TLSv1_1 |
  17. SSL_OP_NO_COMPRESSION);
  18. SSL_CTX_set_mode(newctx, SSL_MODE_ENABLE_PARTIAL_WRITE);
  19. - SSL_CTX_set_verify(newctx, SSL_VERIFY_PEER|SSL_VERIFY_CLIENT_ONCE,
  20. - Verify_openssl);
  21. SSL_CTX_free(ssl_ctx);
  22. ssl_ctx = newctx;
  23. Log(LOG_INFO, "%s initialized.", OpenSSL_version(OPENSSL_VERSION));
  24. @@ -615,7 +613,6 @@
  25. {
  26. X509_STORE *store = NULL;
  27. X509_LOOKUP *lookup;
  28. - int verify_flags = SSL_VERIFY_PEER;
  29. bool ret = false;
  30. if (!Conf_SSLOptions.CAFile)
  31. @@ -649,7 +646,8 @@
  32. }
  33. }
  34. - SSL_CTX_set_verify(ctx, verify_flags, Verify_openssl);
  35. + SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER|SSL_VERIFY_CLIENT_ONCE,
  36. + Verify_openssl);
  37. SSL_CTX_set_verify_depth(ctx, MAX_CERT_CHAIN_LENGTH);
  38. ret = true;
  39. out: